fix block mask typing #36661
Merged
fix block mask typing #36661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cyril Vallez <[email protected]>
Cyrilvallez
approved these changes
Mar 12, 2025
Comment on lines
+856
to
+858
| if fixed_param_name not in expected_keys: | ||
| continue | ||
|
|
Member
There was a problem hiding this comment.
BTW, this was done on purpose, to load the Gemma3CausalLM with accelerate. Before the TP loading was updated, we cropped prefix only after checking existence in expected keys
Member
There was a problem hiding this comment.
For model actually modifying the keys, checking the serialized keys will basically skip everything 😅 Anyway, we will merge #36033 which will use a single key renaming at the very beginning to avoid these issues
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
pushed a commit
that referenced
this pull request
Mar 12, 2025
* fix block mask typing * updated Co-authored-by: Cyril Vallez <[email protected]> * gemma * fix --------- Co-authored-by: Cyril Vallez <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Super nit