Repository navigation
Support batch size > 1 image-text inference #36682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f26b275
update make nested image list
hiyouga 26d2aeb
fix make flat list of images
hiyouga 98a64cb
update type anno
hiyouga 5ab405d
fix image_processing_smolvlm
hiyouga a6153a6
use first image
hiyouga 9596e3a
add verbose comment
hiyouga d86d963
fix images
hiyouga 8b2a747
rollback
hiyouga e484f54
fix ut
hiyouga 6c17ddc
Merge branch 'main' into patch-14
hiyouga 07b9418
Update image_processing_smolvlm.py
hiyouga f728c4f
Update image_processing_idefics3.py
hiyouga a1c6357
Merge branch 'main' into patch-14
qubvel 524ae5b
Merge branch 'main' into patch-14
hiyouga 05119a4
Merge branch 'main' into patch-14
qubvel 4523207
merge main
zucchini-nlp dab0b33
add tests and fix some processors
zucchini-nlp 8bde8d2
fix copies
zucchini-nlp 38bb0db
merge main
zucchini-nlp c564209
fix after rebase
zucchini-nlp 8e5fab9
make the test cover chat templates
zucchini-nlp 2b342df
sjip udop, no point in fixing it
zucchini-nlp 420bfc5
Merge branch 'main' into patch-14
zucchini-nlp 59fa41a
Merge branch 'main' into patch-14
zucchini-nlp e71bef3
fix after rebase
zucchini-nlp 8e4c67a
fix a few more tests
zucchini-nlp d9a5d13
Merge branch 'main' into patch-14
zucchini-nlp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't get why this doesn't throw error anymore, IMO passing flat images is ambiguous, and we throw errors instead of trying to infer which text corresponds to which image