Final CI cleanup #36703
Merged
Final CI cleanup #36703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketknight1
force-pushed
the
final-ci-cleanup
branch
from
fa2d2de to
fbfec54
Compare
gante
reviewed
Mar 13, 2025
gante
approved these changes
Mar 13, 2025
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM, and perhaps add a TODO (code_owner) in the skipped tests?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gante's recent PR has mostly resolved the CI issues, but there are a couple more problems left to fix! One is a flaky issue with an unusual error message that isn't caught by the pytest retry pattern, and the other two are actual failures that are blocking the CI. I'm skipping them for now, but we'll need to deal with those.