Skip to content

Make the flaky list a little more general #36704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rocketknight1 merged 3 commits into from
Mar 14, 2025
Merged

Make the flaky list a little more general #36704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3731865
Make the flaky list a little more general
Rocketknight1 Mar 13, 2025
1c7aff7
Trigger tests
Rocketknight1 Mar 13, 2025
41b32b7
Make the flaky list a little more general
Rocketknight1 Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .circleci/create_circleci_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
"ConnectionError", # Connection transient error
"FileNotFoundError", # Raised by `datasets` on Hub failures
"PIL.UnidentifiedImageError", # Raised by `PIL.Image.open` on connection issues
"HTTPError.*502", # Hub-related
"HTTPError.*504", # Hub-related
"HTTPError", # Also catches HfHubHTTPError
"AssertionError: Tensor-likes are not close!", # `torch.testing.assert_close`, we might have unlucky random values
# TODO: error downloading tokenizer's `merged.txt` from hub can cause all the exceptions below. Throw and handle
# them under a single message.
Expand Down
2 changes: 2 additions & 0 deletions tests/test_image_processing_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from transformers.image_utils import AnnotationFormat, AnnotionFormat
from transformers.testing_utils import (
check_json_file_has_correct_format,
is_flaky,
require_torch,
require_torch_gpu,
require_vision,
Expand Down Expand Up @@ -212,6 +213,7 @@ def test_slow_fast_equivalence_batched(self):

@require_vision
@require_torch
@is_flaky()
def test_fast_is_faster_than_slow(self):
if not self.test_slow_image_processor or not self.test_fast_image_processor:
self.skipTest(reason="Skipping speed test")
Expand Down