Skip to content

Conversation

@Kim-Ju-won
Copy link
Contributor

@Kim-Ju-won Kim-Ju-won commented Mar 17, 2025

What does this PR do?

Translated the electra.md file of the documentation to Korean.
Thank you in advance for your review.

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review?

@cjfghk5697, @yijun-lee, @junhkang, @olccihyeon

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@github-actions github-actions bot marked this pull request as draft March 17, 2025 11:26
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@Rocketknight1
Copy link
Member

cc @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation! We can merge once a Korean reviewer has had a chance to take a look as well 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yijun-lee
Copy link
Contributor

@MinJu-Ha

@stevhliu
Copy link
Member

Feel free to mark it as ready for review when you're done and I can merge! 🤗

@Kim-Ju-won Kim-Ju-won marked this pull request as ready for review April 29, 2025 15:31
@Kim-Ju-won
Copy link
Contributor Author

Kim-Ju-won commented Apr 29, 2025

@stevhliu Thanks for the comments! I’ve marked it as ready. 😄

@stevhliu stevhliu merged commit 50f8caa into huggingface:main Apr 29, 2025
10 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* docs: ko: electra.md

* feat: nmt draft

* fix: manual edits

* fix: manual edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants