Skip to content

Conversation

@Zebz13
Copy link
Contributor

@Zebz13 Zebz13 commented Mar 17, 2025

What does this PR do?

Removes typo present in Gemma3 Model's ImageProcessorFast.
Added 1 small test for the verification of the same.
Fixes #36739

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum?
    Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

PR Discussion - #36739
Added small test for Gemma3 model with do_pan_and_scan disabled.

Who can review?

@zucchini-nlp

@github-actions github-actions bot marked this pull request as draft March 17, 2025 21:14
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@Zebz13 Zebz13 marked this pull request as ready for review March 17, 2025 21:19
@ydshieh ydshieh requested review from zucchini-nlp and removed request for ydshieh March 18, 2025 09:24
Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh ydshieh merged commit 7426d02 into huggingface:main Mar 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnboundLocalError: cannot access local variable 'images_list' when using Gemma 3 AutoProcessor with use_fast=True

3 participants