Skip to content

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 20, 2025

What does this PR do?

Refactor code to use syntax and library functions from Python 3.9.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@cyyever cyyever marked this pull request as draft March 20, 2025 02:37
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@cyyever cyyever force-pushed the pyupdate39_4 branch 10 times, most recently from b287296 to 099bfec Compare March 20, 2025 02:58
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Whenever you're ready, you should:

  1. Mark this "Ready for review"
  2. Rebase / resolve conflicts - this touches a lot of files, so you may have to rebase repeatedly to avoid conflicts with new commits!
  3. Ping me to merge it

@cyyever cyyever changed the title Use pyupgrade --py39-plus to improve type annotations Use pyupgrade --py39-plus to improve code Mar 20, 2025
@cyyever cyyever marked this pull request as ready for review March 20, 2025 13:26
@cyyever
Copy link
Contributor Author

cyyever commented Mar 20, 2025

@Rocketknight1 Ready

@cyyever cyyever force-pushed the pyupdate39_4 branch 2 times, most recently from 18669c8 to 3f6ebc1 Compare March 20, 2025 14:00
@Rocketknight1
Copy link
Member

@cyyever testing the doc build with these new changes, will merge once that passes. Thank you for the PR!

@Rocketknight1
Copy link
Member

Update: Doc builds are failing on main right now, but this isn't your fault. Going to merge this PR and then investigate that!

@Rocketknight1 Rocketknight1 merged commit ce091b1 into huggingface:main Mar 20, 2025
22 of 23 checks passed
@cyyever
Copy link
Contributor Author

cyyever commented Mar 20, 2025

@Rocketknight1 Thank you for quick responds, the document CI failures seem unrelated to this PR.

@cyyever cyyever deleted the pyupdate39_4 branch March 22, 2025 00:35
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants