Skip to content

Add weights_only=True to torch.load #37062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rocketknight1 merged 1 commit into from
Apr 11, 2025
Merged

Add weights_only=True to torch.load #37062

Rocketknight1 merged 1 commit into from
Apr 11, 2025

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 28, 2025

What does this PR do?

Use weights_only=True in all code.

@github-actions github-actions bot marked this pull request as draft March 28, 2025 04:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@cyyever cyyever marked this pull request as ready for review March 28, 2025 04:59
@Rocketknight1
Copy link
Member

Rocketknight1 commented Mar 28, 2025

Most of these conversion scripts are already excluded from release builds, but I think this is good for reducing warnings + adding security. cc @ArthurZucker are you okay with it, or is there any risk of breaking things?

@cyyever cyyever force-pushed the torchfix branch 3 times, most recently from 060c69f to 12d357c Compare March 31, 2025 14:21
@cyyever
Copy link
Contributor Author

cyyever commented Apr 11, 2025

PT2.6 defaults weights_only to Ture.

@Rocketknight1
Copy link
Member

Rocketknight1 commented Apr 11, 2025

Good point, actually - this PR only affects older versions, so it should be completely safe, and everyone using torch 2.6 is already "testing" it. Going to merge without core maintainers since it should be totally non-breaking!

@Rocketknight1 Rocketknight1 merged commit 28eae8b into huggingface:main Apr 11, 2025
9 checks passed
@Rocketknight1 Rocketknight1 removed the request for review from ArthurZucker April 11, 2025 16:18
@cyyever cyyever deleted the torchfix branch April 11, 2025 16:48
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
@cyyever
Add weights_only=True to torch.load (huggingface#37062)
1af2863
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@cyyever @zucchini-nlp
Add weights_only=True to torch.load (huggingface#37062)
a1f0f18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rocketknight1 Rocketknight1 Rocketknight1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyyever @Rocketknight1