Add Fast Conditional-DETR Processor #37071
Conversation
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
Hi @keetrap, before I dive deep into the code, could you check if it would be useful to use modular here, as this image processor seems to have some similarities with other DETR image processors? You can look at the modular files of Deformable DETR and RT DETR to see how it's done. Thanks for working on this! |
|
@yonigozlan Thanks for the review. I’ve added the modular file. The tests are failing here, but they’re passing locally. |
yonigozlan
left a comment
yonigozlan
left a comment
There was a problem hiding this comment.
Thanks looks great @keetrap , last thing to do is make sure that both classes are tested in all image processing tests
yonigozlan
left a comment
yonigozlan
left a comment
There was a problem hiding this comment.
Thanks for making the changes! LGTM, but let's wait for @ArthurZucker final approval before
|
Hi @keetrap ! Could you merge with main and run |
* Add Fast Conditional-DETR Processor * Update image_processing_conditional_detr_fast.py * Add modular_conditional_detr.py * Update image_processing_conditional_detr_fast.py * Update tests * make fix --------- Co-authored-by: Yoni Gozlan <[email protected]>
* Add Fast Conditional-DETR Processor * Update image_processing_conditional_detr_fast.py * Add modular_conditional_detr.py * Update image_processing_conditional_detr_fast.py * Update tests * make fix --------- Co-authored-by: Yoni Gozlan <[email protected]>
3 participants
Related #36978
cc @yonigozlan