Skip to content

Conversation

@devxaitist
Copy link
Contributor

What does this PR do?

Translated the siglip.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
@cjfghk5697, @yijun-lee, @rlaalsrl0922 , @MinJu-Ha

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@Rocketknight1
Copy link
Member

cc @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we can merge once a Korean reader has reviewed!

@devxaitist
Copy link
Contributor Author

Thanks, we can merge once a Korean reader has reviewed!

Thank you! I've updated the title to kebab-case format as suggested. Looking forward to having it merged after a Korean reader's review. I appreciate your guidance on my first open source contribution.

@devxaitist devxaitist marked this pull request as ready for review April 5, 2025 15:32
@jungnerd
Copy link
Contributor

jungnerd commented Apr 6, 2025

Hey @devxaitist 👋
Thanks for the translation. I'll review it tonight!

@yijun-lee
Copy link
Contributor

yijun-lee commented Apr 18, 2025

In my opinion, only the two parts above need to be revised!

Convert unnatural language to natural Korean

Co-authored-by: Yijun Lee <[email protected]>
@devxaitist
Copy link
Contributor Author

In my opinion, only the two parts above need to be revised!

Thank you for your feedback. I have made changes to reflect your feedback, please review.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
Copy link
Member

Merging since the requested changes have been applied. Thanks again everyone! 🤗

@stevhliu stevhliu merged commit fbfa1dd into huggingface:main Apr 22, 2025
10 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* docs: ko: siglip.md

* feat: nmt draft

* fix: manual edits

* chore: Correct document title to kebab-case format

Co-authored-by: Steven Liu <[email protected]>

* Apply suggestions from code review

Convert unnatural language to natural Korean

Co-authored-by: Yijun Lee <[email protected]>

---------

Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Yijun Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants