-
Notifications
You must be signed in to change notification settings - Fork 31.7k
🌐 [i18n-KO] Translated siglip.md to Korean
#37145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @stevhliu |
stevhliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we can merge once a Korean reader has reviewed!
Co-authored-by: Steven Liu <[email protected]>
Thank you! I've updated the title to kebab-case format as suggested. Looking forward to having it merged after a Korean reader's review. I appreciate your guidance on my first open source contribution. |
|
Hey @devxaitist 👋 |
|
In my opinion, only the two parts above need to be revised! |
Convert unnatural language to natural Korean Co-authored-by: Yijun Lee <[email protected]>
Thank you for your feedback. I have made changes to reflect your feedback, please review. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Merging since the requested changes have been applied. Thanks again everyone! 🤗 |
* docs: ko: siglip.md * feat: nmt draft * fix: manual edits * chore: Correct document title to kebab-case format Co-authored-by: Steven Liu <[email protected]> * Apply suggestions from code review Convert unnatural language to natural Korean Co-authored-by: Yijun Lee <[email protected]> --------- Co-authored-by: Steven Liu <[email protected]> Co-authored-by: Yijun Lee <[email protected]>
What does this PR do?
Translated the
siglip.mdfile of the documentation to Korean.Thank you in advance for your review.
Part of #20179
Before reviewing
[[lowercased-header]])Who can review? (Initial)
May you please review this PR?
@cjfghk5697, @yijun-lee, @rlaalsrl0922 , @MinJu-Ha
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review? (Final)