Skip to content

Conversation

@ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Mar 31, 2025

What does this PR do?

As described in the issue, this PR updates the model card for Jamba. I've chosen to also add the newer Jamba-Large-1.6 and Mini models in the model card as well and notes for loading the model using accelerate and BnB. Please let me know if any modifications are required and I will make the necessary changes.

#36979

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

@stevhliu

@github-actions github-actions bot marked this pull request as draft March 31, 2025 17:31
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@ParagEkbote ParagEkbote marked this pull request as ready for review March 31, 2025 17:31
@github-actions github-actions bot requested a review from stevhliu March 31, 2025 17:31
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! 🤗

@ParagEkbote ParagEkbote requested a review from stevhliu April 2, 2025 18:18
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few more changes!

<hfoption id="AutoModel">

### Run the model
```python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitsandbytes is a nice and easy choice for inference 👍

You should have an un-quantized version as well though. So:

<hfoptions id="usage">
<hfoption id="Pipeline">

...

</hfoption>
<hfoption id="AutoModel">

unquantized example

</hfoption>
</hfoptions

Add quantization example here

@ParagEkbote
Copy link
Contributor Author

Could you please review the changes?

cc: @stevhliu

@ParagEkbote ParagEkbote requested a review from stevhliu April 5, 2025 16:16
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 🤗

@stevhliu stevhliu merged commit e2b0224 into huggingface:main Apr 7, 2025
10 checks passed
@ParagEkbote ParagEkbote deleted the Model-Card-For-Jamba branch April 7, 2025 18:05
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
* Update model card for jamba

* Apply the suggestions from code review

Co-authored-by: Steven Liu <[email protected]>

* Apply suggestions from code review-2

Co-authored-by: Steven Liu <[email protected]>

* update model page.

* Apply suggestions from code review

Co-authored-by: Steven Liu <[email protected]>

* Update as per code review.

* Update docs/source/en/model_doc/jamba.md as per code review

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/jamba.md as per code review

`

Co-authored-by: Steven Liu <[email protected]>

* update as per code review.

* fixes

---------

Co-authored-by: Steven Liu <[email protected]>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* Update model card for jamba

* Apply the suggestions from code review

Co-authored-by: Steven Liu <[email protected]>

* Apply suggestions from code review-2

Co-authored-by: Steven Liu <[email protected]>

* update model page.

* Apply suggestions from code review

Co-authored-by: Steven Liu <[email protected]>

* Update as per code review.

* Update docs/source/en/model_doc/jamba.md as per code review

Co-authored-by: Steven Liu <[email protected]>

* Update docs/source/en/model_doc/jamba.md as per code review

`

Co-authored-by: Steven Liu <[email protected]>

* update as per code review.

* fixes

---------

Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants