Skip to content

Conversation

@Cyrilvallez
Copy link
Member

What does this PR do?

I stumbled upon the 2 unused functions in from_pretrained and they are not used anywhere in the codebase.

@github-actions github-actions bot marked this pull request as draft April 2, 2025 17:04
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@Cyrilvallez Cyrilvallez marked this pull request as ready for review April 2, 2025 17:04
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, if they're not being used then there's no point keeping them!

@Cyrilvallez Cyrilvallez merged commit cdfb018 into main Apr 8, 2025
19 of 21 checks passed
@Cyrilvallez Cyrilvallez deleted the some-cleanup branch April 8, 2025 12:33
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants