Skip to content

Conversation

@jmkuebler
Copy link
Contributor

@jmkuebler jmkuebler commented Apr 8, 2025

What does this PR do?

no_rope_layers should either be a list of NoPE layers or None, such that it is created in the config from the no_rope_layer_interval, see https://github.com/huggingface/transformers/blob/main/src/transformers/models/llama4/configuration_llama4.py#L338-L343

Fixes (incompatibility issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @Vaibhavs10

`no_rope_layers` should either be a list of NoPE layers or None, such that it is created in the config from the `no_rope_layer_interval`
@github-actions github-actions bot marked this pull request as draft April 8, 2025 07:17
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@ArthurZucker ArthurZucker requested a review from pcuenca April 8, 2025 11:49
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jmkuebler for the PR and the investigation in the Llama Scout repo! 🙌

You are right, the conversion script needs to be updated, and no_rope_layers should default to None, which will use the default setting (every fourth layer uses NoPE).

For more info, this PR is somewhat related too: https://github.com/huggingface/transformers/pull/37344/files

@jmkuebler jmkuebler marked this pull request as ready for review April 8, 2025 20:47
@jmkuebler
Copy link
Contributor Author

@pcuenca I set the pr from draft to ready, but not sure this is how it should be done. Anything needed from my side still?

@pcuenca
Copy link
Member

pcuenca commented Apr 9, 2025

Yes, this is correct, merging. Thank you @jmkuebler!

@pcuenca pcuenca merged commit 1e6ff5f into huggingface:main Apr 9, 2025
10 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
fix conversion script no_rope_layers

`no_rope_layers` should either be a list of NoPE layers or None, such that it is created in the config from the `no_rope_layer_interval`

Co-authored-by: Pedro Cuenca <[email protected]>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
fix conversion script no_rope_layers

`no_rope_layers` should either be a list of NoPE layers or None, such that it is created in the config from the `no_rope_layer_interval`

Co-authored-by: Pedro Cuenca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants