-
Notifications
You must be signed in to change notification settings - Fork 31.7k
fix: llama4 conversion script no_rope_layers #37359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`no_rope_layers` should either be a list of NoPE layers or None, such that it is created in the config from the `no_rope_layer_interval`
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
pcuenca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jmkuebler for the PR and the investigation in the Llama Scout repo! 🙌
You are right, the conversion script needs to be updated, and no_rope_layers should default to None, which will use the default setting (every fourth layer uses NoPE).
For more info, this PR is somewhat related too: https://github.com/huggingface/transformers/pull/37344/files
|
@pcuenca I set the pr from draft to ready, but not sure this is how it should be done. Anything needed from my side still? |
|
Yes, this is correct, merging. Thank you @jmkuebler! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
fix conversion script no_rope_layers `no_rope_layers` should either be a list of NoPE layers or None, such that it is created in the config from the `no_rope_layer_interval` Co-authored-by: Pedro Cuenca <[email protected]>
fix conversion script no_rope_layers `no_rope_layers` should either be a list of NoPE layers or None, such that it is created in the config from the `no_rope_layer_interval` Co-authored-by: Pedro Cuenca <[email protected]>
What does this PR do?
no_rope_layersshould either be a list of NoPE layers orNone, such that it is created in the config from theno_rope_layer_interval, see https://github.com/huggingface/transformers/blob/main/src/transformers/models/llama4/configuration_llama4.py#L338-L343Fixes (incompatibility issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker @Vaibhavs10