Skip to content

Conversation

@duanjunwen
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@duanjunwen duanjunwen marked this pull request as ready for review April 9, 2025 05:31
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @duanjunwen, this looks good, but please pip install -e .[quality] and make style to resolve the code formatting errors!

@duanjunwen
Copy link
Contributor Author

duanjunwen commented Apr 9, 2025

Hi @duanjunwen, this looks good, but please pip install -e .[quality] and make style to resolve the code formatting errors!

Hi Rocketknight1, code formatting has been fixed in 5987463

@duanjunwen duanjunwen requested a review from Rocketknight1 April 9, 2025 14:36
Copy link
Member

@ivarflakstad ivarflakstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ivarflakstad ivarflakstad merged commit 7ff896c into huggingface:main Apr 10, 2025
20 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants