Skip to content

Conversation

@SunMarc
Copy link
Member

@SunMarc SunMarc commented Apr 8, 2025

What does this PR do?

This PR updates deepspeed docker so that we run our tests with pytorch 2.6

@SunMarc SunMarc requested a review from ydshieh April 8, 2025 15:57
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft April 8, 2025 15:57
@SunMarc SunMarc marked this pull request as ready for review April 8, 2025 16:07
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

name: "Latest PyTorch + DeepSpeed"
runs-on:
group: aws-general-8-plus
group: aws-g4dn-2xlarge-cache
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the real change in this file. other places are just space issues.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this otherwise the build fails. No idea, looks like g++ versions issues.


RUN python3 -m pip install --no-cache-dir ./transformers[deepspeed-testing]
# `datasets` requires pandas, pandas has some modules compiled with numpy=1.x causing errors
RUN python3 -m pip install --no-cache-dir './transformers[deepspeed-testing]' 'pandas<2' 'numpy<2'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nightly image is not the current focus, but I went forward and the build works locally.

Let's update the docker file anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but i think that we are not really installing deepspeed from source in this dockerfile. But as you said, this is not the current focus and not sure this is needed for now

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SunMarc . As mentioned, I will try to adjust the report stuff.

@SunMarc
Copy link
Member Author

SunMarc commented Apr 9, 2025

Thanks for your help @ydshieh !

@SunMarc SunMarc merged commit 7ae0be7 into main Apr 9, 2025
11 checks passed
@SunMarc SunMarc deleted the update-deepspeed-docker branch April 9, 2025 12:54
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
* update

* create docker image

* 03

* uninstall pytest as it conflits with transformers

* wrong one

* better

* see which package depends on pytest

* up

* resintall

* fix

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

---------

Co-authored-by: ydshieh <[email protected]>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* update

* create docker image

* 03

* uninstall pytest as it conflits with transformers

* wrong one

* better

* see which package depends on pytest

* up

* resintall

* fix

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

* deepspeedddddddd

---------

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants