Skip to content

Conversation

@MekkCyber
Copy link
Contributor

What does this PR do?

Explains the tp_plan for fbgemm implementation

@MekkCyber MekkCyber requested a review from SunMarc April 9, 2025 21:22
@github-actions github-actions bot marked this pull request as draft April 9, 2025 21:22
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@MekkCyber MekkCyber marked this pull request as ready for review April 9, 2025 21:38
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much better

@MekkCyber MekkCyber merged commit f5865d3 into main Apr 10, 2025
21 checks passed
@MekkCyber MekkCyber deleted the add_doc_tp branch April 10, 2025 09:33
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
* explain tp_plan

* add llama4 check

* add clarification
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* explain tp_plan

* add llama4 check

* add clarification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants