remove _run_third_party_device_tests #37445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
Signed-off-by: jiqing-feng <[email protected]>
SunMarc
approved these changes
Apr 14, 2025
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Yeah, not sure if this is really needed cc @ji-huazhong
It was introduced here #25327
Contributor
|
@SunMarc, do we need more people to discuss on this from Hugging Face side. From our side, we think it's great that we remove |
Member
|
yeah should be safe to merge, looks like @ji-huazhong is fine with the change |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
Signed-off-by: jiqing-feng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @SunMarc . I ran the transformers tests for XPU and found that the
_run_third_party_device_testsblocks me from setting XPU as the device unless I set the parameter. I cannot see any reason to keep this parameter. There is no limitation for CUDA, so I suppose we should not have limitations for other devices like XPU.