Skip to content

Conversation

@MekkCyber
Copy link
Contributor

What does this PR do?

Removing the mlp triton kernel because of some failures on the CI, and disabling the use of kernels on the CI

@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft April 11, 2025 09:33
@MekkCyber MekkCyber requested a review from ArthurZucker April 11, 2025 09:57
@MekkCyber MekkCyber marked this pull request as ready for review April 11, 2025 10:02
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@MekkCyber MekkCyber merged commit 3c39c07 into main Apr 11, 2025
17 checks passed
@MekkCyber MekkCyber deleted the fix_kernels_models branch April 11, 2025 10:47
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@zheliuyu
Copy link
Contributor

@MekkCyber @ArthurZucker Hi, regarding the mlp kernel, is there a plan to fix it and re-enable it via use_kernel_forward_from_hub? I noticed that the relevant code hasn't been removed yet.

@MekkCyber
Copy link
Contributor Author

Hey @zheliuyu, good catch maybe we should remove it from the dict for now, and yes sure we are trying to optimize our modeling and using an mlp kernel is a good option that we will re-enable once we have a good kernel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants