Don't auto-assign reviewers when the author is in HF #37500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @ydshieh! |
ydshieh
reviewed
Apr 14, 2025
Comment on lines
+58
to
+70
| # Check if the PR author is in the codeowners file | ||
| for line in codeowners_lines: | ||
| line = line.split('#')[0].strip() | ||
| if not line: | ||
| continue | ||
|
|
||
| # Split into pattern and owners | ||
| parts = line.split() | ||
| owners = [owner.removeprefix("@") for owner in parts[1:]] | ||
|
|
||
| if pr_author in owners: | ||
| return True | ||
| return False |
Collaborator
There was a problem hiding this comment.
could we simply using a regex with f'@{pr_autho}' against the codeowner file content? It's justa nit so up to you, but potentially a one line code.
Member
Author
There was a problem hiding this comment.
It'd probably work, but it feels just the tiniest bit fragile to me, like it'll be harder to change if we ever change any file formats or anything! You're probably right, but I'm going to leave it as-is just because I'm paranoid, lol
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
cyr0930
pushed a commit
to cyr0930/transformers
that referenced
this pull request
Apr 18, 2025
* Don't auto-assign reviewers when the author is in HF * Trigger tests
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* Don't auto-assign reviewers when the author is in HF * Trigger tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, we don't want to auto-assign reviewers for staff authors because they can do it themselves (and probably more accurately)