Fix BitsAndBytesConfig JSON serialization in TrainingArguments #37520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
astefanutti
force-pushed
the
fix-bnb-json
branch
from
50ae468 to
b63abbe
Compare
MekkCyber
approved these changes
Apr 15, 2025
Contributor
MekkCyber
left a comment
MekkCyber
left a comment
There was a problem hiding this comment.
Sounds good ! left a very small nit
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
astefanutti
force-pushed
the
fix-bnb-json
branch
2 times, most recently
from
1fd29a0 to
0ffc789
Compare
astefanutti
force-pushed
the
fix-bnb-json
branch
from
0ffc789 to
74d70c1
Compare
cyr0930
pushed a commit
to cyr0930/transformers
that referenced
this pull request
Apr 18, 2025
…ngface#37520) Co-authored-by: Mohamed Mekkouri <[email protected]>
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
…ngface#37520) Co-authored-by: Mohamed Mekkouri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes sure the BitsAndBytesConfig object gets converted to dict before TrainingArguments are serialized to JSON.
This happens when using BitsAndBytes and the TensorBoard integration for example.
Fixes #37518
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zach-huggingface @SunMarc @MekkCyber