Skip to content

Fix qwen2audio wanr -> warn #37559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rocketknight1 merged 1 commit into from
Apr 17, 2025
Merged

Fix qwen2audio wanr -> warn #37559

Rocketknight1 merged 1 commit into from
Apr 17, 2025

Conversation

@alex-jw-brooks
Copy link
Contributor

@alex-jw-brooks alex-jw-brooks commented Apr 16, 2025 •
edited
Loading

What does this PR do?

Fixes a typo for warnings.wanr -. warnings.warn in the qwen2 audio processor. Should not really be reachable because of the deprecation decorator, but maybe still nice to fix anyway!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@eustlb

@alex-jw-brooks
Fix qwen2audio wanr -> warn
c6816e0 
Signed-off-by: Alex-Brooks <[email protected]>
@github-actions github-actions bot marked this pull request as draft April 16, 2025 17:14
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@alex-jw-brooks alex-jw-brooks marked this pull request as ready for review April 16, 2025 17:15
@github-actions github-actions bot requested review from molbap and yonigozlan April 16, 2025 17:15
Rocketknight1
Rocketknight1 approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The comment typos are merely embarrassing, but the typo on wanr will cause a crash, so this is greatly appreciated.

@Rocketknight1 Rocketknight1 merged commit c7d3cc6 into huggingface:main Apr 17, 2025
11 checks passed
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
@alex-jw-brooks
Fix qwen2audio wanr -> warn (huggingface#37559)
dad762b 
Signed-off-by: Alex-Brooks <[email protected]>
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
@alex-jw-brooks @zucchini-nlp
Fix qwen2audio wanr -> warn (huggingface#37559)
c07d43a 
Signed-off-by: Alex-Brooks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rocketknight1 Rocketknight1 Rocketknight1 approved these changes

@molbap molbap Awaiting requested review from molbap

@yonigozlan yonigozlan Awaiting requested review from yonigozlan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-jw-brooks @Rocketknight1