Skip to content

Conversation

@yao-matrix
Copy link
Contributor

@yao-matrix yao-matrix commented Apr 16, 2025

2 pass
PASSED tests/models/gemma2/test_modeling_gemma2.py::Gemma2IntegrationTest::test_export_static_cache
PASSED tests/models/gemma2/test_modeling_gemma2.py::Gemma2IntegrationTest::test_generation_beyond_sliding_window_3_eager

1 should skip: XPU doesn't support flash-attention-2 package as of now
SKIPPPED tests/models/gemma2/test_modeling_gemma2.py::Gemma2IntegrationTest::test_generation_beyond_sliding_window_0_flash_attention_2

2 flex_attention failed, already in development plan
FAILED tests/models/gemma2/test_modeling_gemma2.py::Gemma2IntegrationTest::test_generation_beyond_sliding_window_2_flex_attention
FAILED tests/models/gemma2/test_modeling_gemma2.py::Gemma2IntegrationTest::test_model_2b_pipeline_bf16_flex_attention

1 repetition output when out seq is long, under debug, will submit separate PR if needed
tests/models/gemma2/test_modeling_gemma2.py::Gemma2IntegrationTest::test_generation_beyond_sliding_window_1_sdpa

@github-actions github-actions bot marked this pull request as draft April 16, 2025 23:35
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@yao-matrix yao-matrix marked this pull request as ready for review April 16, 2025 23:46
@github-actions github-actions bot requested a review from ydshieh April 16, 2025 23:46
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ydshieh
Copy link
Collaborator

ydshieh commented Apr 17, 2025

@yao-matrix I have seen the run-test is not triggered. Could you click "Convert to draft" then "ready for review"? I am just trying to see what might cause this situation 🙏

@yao-matrix yao-matrix marked this pull request as draft April 17, 2025 22:34
@yao-matrix yao-matrix marked this pull request as ready for review April 17, 2025 22:34
@yao-matrix
Copy link
Contributor Author

@yao-matrix I have seen the run-test is not triggered. Could you click "Convert to draft" then "ready for review"? I am just trying to see what might cause this situation 🙏

done, thx

@ydshieh ydshieh merged commit 3cd6627 into huggingface:main Apr 18, 2025
13 checks passed
@yao-matrix yao-matrix deleted the gemma2-xpu branch April 20, 2025 22:46
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants