Skip to content

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 17, 2025

What does this PR do?

Can't say anything why #37553 gives some tests GPU OOM and the only way I can make those tests to pass is to do some cuda cleanup at some places.

@github-actions github-actions bot marked this pull request as draft April 17, 2025 18:03
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@ydshieh ydshieh marked this pull request as ready for review April 17, 2025 18:09
@ydshieh ydshieh requested a review from Copilot April 17, 2025 18:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ydshieh ydshieh requested a review from Cyrilvallez April 17, 2025 18:09
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh marked this pull request as draft April 17, 2025 18:50
@ydshieh ydshieh marked this pull request as ready for review April 17, 2025 18:50
@ydshieh ydshieh marked this pull request as draft April 17, 2025 19:22
@ydshieh ydshieh marked this pull request as ready for review April 17, 2025 19:22
Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ydshieh ydshieh merged commit f974214 into main Apr 18, 2025
18 checks passed
@ydshieh ydshieh deleted the fix_oom branch April 18, 2025 08:09
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* fix

* trigger CI

---------

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants