[test] update test_past_key_values_format
#37614
Conversation
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks for fixing it, has been annoying me a lot lately 😆
|
|
||
| @pytest.mark.generate | ||
| # overridden because mllama has special cache for self and cross attentions | ||
| # overridden because mllama is not an encoder-decoder model, but has encoder-decoder-like cache |
There was a problem hiding this comment.
could also call super() with custom shapes, no?
There was a problem hiding this comment.
Sadly no :(
config.is_encoder_decoder is False -> doesn't perform encoder cache shape checks in the base test
allow custom shapes
3 participants
What does this PR do?
tests/models/speecht5/test_modeling_speecht5.py::SpeechT5ForSpeechToTextTest::test_past_key_values_formatwas flaky, so a revisit was in order.This PR rewrites
test_past_key_values_formatso that:CacheobjectsIn the process, many model-level skips were removed 🤗