[fix gemma] Set default value for output_attentions parameter in Gemma2 and Gemma… #37633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
Contributor
Author
chenin-wang
changed the title
Contributor
Author
|
Why does it work locally without errors, but always fails in CircleCI? @zucchini-nlp
|
Member
|
@chenin-wang hm, there are changes in unrelated files which is causing red CI because we then need to update all files from where it was copied. Usually it is fixed by I am not sure why it is being modified, prob |
Contributor
Author
|
@zucchini-nlp Hi, I've found the problem. Can you help me review it? |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
…a2 and Gemma… (huggingface#37633) * Set default value for output_attentions parameter in Gemma2 and Gemma3 models * update * fix * fix --------- Co-authored-by: chenin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set default value for output_attentions parameter in Gemma2 and Gemma3
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker @zucchini-nlp