Skip to content

Add test to ensure unknown exceptions reraising in utils/hub.py::cached_files() #37651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manueldeprada merged 3 commits into from
Apr 22, 2025
Merged

Add test to ensure unknown exceptions reraising in utils/hub.py::cached_files() #37651

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90e00fd
add test to ensure unknown exceptions reraising in utils/hub.py::cach…
manueldeprada Apr 21, 2025
fdf83e9
Merge branch 'main' into add-hub-test
manueldeprada Apr 21, 2025
183d8f4
use public wrapper cached_file instead of cached_files; use model fro…
manueldeprada Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/utils/test_hub_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,3 +189,12 @@ def test_has_file_gated_repo(self):
with self.assertRaisesRegex(EnvironmentError, "is a gated repository"):
# All files except README.md are protected on a gated repo.
has_file(GATED_REPO, "gated_file.txt", token=False)

def test_cached_files_exception_raised(self):
"""Test that unhadled exceptions, e.g. ModuleNotFoundError, is properly re-raised by cached_files when hf_hub_download fails."""
with mock.patch(
"transformers.utils.hub.hf_hub_download", side_effect=ModuleNotFoundError("No module named 'MockModule'")
):
with self.assertRaises(ModuleNotFoundError):
# The error should be re-raised by cached_files, not caught in the exception handling block
cached_file(RANDOM_BERT, "nonexistent.json")