Fix no_split_modules for Llama4 pretrained models #37673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
astefanutti
force-pushed
the
fix-llama4-no-split-modules
branch
from
771dd68 to
e5976aa
Compare
zucchini-nlp
approved these changes
Apr 22, 2025
astefanutti
force-pushed
the
fix-llama4-no-split-modules
branch
2 times, most recently
from
bb8718f to
14483b5
Compare
Contributor
Author
|
@zucchini-nlp thanks, I've just rebased and re-pushed. |
Contributor
Author
|
The CI error seems related to #37675. |
Contributor
|
Hey @astefanutti, should be fixed now ! you can just update the branch |
astefanutti
force-pushed
the
fix-llama4-no-split-modules
branch
from
14483b5 to
0f7432a
Compare
Contributor
Author
|
@MekkCyber thanks for the update, I've just rebased on it. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves the definition of
_no_split_modulesfor Llama4 pre-trained models from the baseLlama4PreTrainedModelclass to the subclasses so each model has the correct set of modules.Otherwise loading the
Llama4ForCausalLMcurrently fails because it doesn't have theLlama4VisionEncoderLayermodule.Fixes #37672
Who can review?
@ArthurZucker @amyeroberts @qubvel