-
Notifications
You must be signed in to change notification settings - Fork 31.6k
enable internvl UTs on XPU #37779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable internvl UTs on XPU #37779
Conversation
Signed-off-by: YAO Matrix <[email protected]>
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
@ydshieh , pls help review, thx |
Signed-off-by: YAO Matrix <[email protected]>
|
@ydshieh @IlyasMoutawwakil , could you help review again? thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Only thing I'm a bit opinionated about is the use of "require_deterministic_for_xpu" because it behaves differently than other "require_xxx". We can probably try getting rid of it if ever the problem with "warn_only=True" was fixed ? #30774 (comment)
it's a new info for me, let me go back to check with our pytorch team, and if OK, i will make update. And at the same time, we are working w/ our pytorch team to root cause this difference btw xpu and cuda. |
ydshieh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Only 2 nits regarding formatting 🙏
Signed-off-by: Yao Matrix <[email protected]>
@ydshieh thx, done per comments. |
* enable internvl UTs on XPU Signed-off-by: YAO Matrix <[email protected]> * fix style Signed-off-by: YAO Matrix <[email protected]> * fix style per comments Signed-off-by: Yao Matrix <[email protected]> --------- Signed-off-by: YAO Matrix <[email protected]> Signed-off-by: Yao Matrix <[email protected]>
pytest -rA tests/models/internvl/test_modeling_internvl.py137 cases PASSED, 4 failed cases are same as CUDA, will investigate in separate efforts.
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_embeddings_untied_with_deepspeed
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_embeddings_untied_with_deepspeed_multi_gpu
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_tokens_embeddings_with_deepspeed
FAILED tests/models/internvl/test_modeling_internvl.py::InternVLModelTest::test_resize_tokens_embeddings_with_deepspeed_multi_gpu