Fix donut backtracking #37788
Merged
Fix donut backtracking #37788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
cc @Michellehbn! I think this is simple enough and we should be able to merge it without too much trouble |
gante
approved these changes
May 1, 2025
| potential_end = re.search(r">", tokens[potential_start.end() :], re.IGNORECASE) | ||
| if potential_end is None: | ||
| break | ||
| start_token = tokens[potential_start.start() : potential_start.end() + potential_end.end()] |
Contributor
There was a problem hiding this comment.
nit: I would add a comment (or create intermediary vars) to help explain the why behind potential_start.end() + potential_end.end() (potential_end searches over a substring)
Member
Author
There was a problem hiding this comment.
Yes, good point! I rewrote that bit.
Rocketknight1
force-pushed
the
fix-donut-backtracking
branch
from
43896b7 to
5a8abeb
Compare
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* Fix donut backtracking * make fixup * Trigger tests * Remove old line * Update code * Fix reversed slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an exploitable regex in the donut processor, this replaces it with less blowup-prone code!