Fix: Correct tensor shape comment in Mamba modeling #37801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
Rocketknight1
approved these changes
Apr 28, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yes, this is correct! Going to fix the spelling of 'intermediate' too before merging.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sushmanthreddy
pushed a commit
to sushmanthreddy/transformers
that referenced
this pull request
Apr 28, 2025
* Fix: Correct tensor shape comment in Mamba modeling * Update src/transformers/models/mamba/modeling_mamba.py * Update src/transformers/models/mamba/modeling_mamba.py --------- Co-authored-by: ShadyPi <[email protected]> Co-authored-by: Matt <[email protected]>
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* Fix: Correct tensor shape comment in Mamba modeling * Update src/transformers/models/mamba/modeling_mamba.py * Update src/transformers/models/mamba/modeling_mamba.py --------- Co-authored-by: ShadyPi <[email protected]> Co-authored-by: Matt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Correct a wrong tensor shape comment in Mamba modeling.
Fixes # (None, as no issue was explicitly mentioned)
The comment on line 307 of
src/transformers/models/mamba/modeling_mamba.pyincorrectly states the shape of the tensorscan_output. It should be[batch, intermediade_size, seq_len]instead of[batch, seq_len, intermediade_size].scan_outputsis a list ofseq_len[batch, intermediade_size]tensors. When stack them on dimension-1, the correct shape should be[batch, intermediade_size, seq_len].Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker @alxndrTL