Skip to content

Conversation

@yao-matrix
Copy link
Contributor

No description provided.

@github-actions github-actions bot marked this pull request as draft May 8, 2025 05:45
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

Signed-off-by: Yao Matrix <[email protected]>
@yao-matrix yao-matrix marked this pull request as ready for review May 8, 2025 05:51
@yao-matrix
Copy link
Contributor Author

@ydshieh , pls help review, thx

@github-actions github-actions bot requested review from ArthurZucker and gante May 8, 2025 05:52
Copy link
Contributor

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM 🤗

(@ydshieh the device-related changes seem sensible to me, but please a look at them too 🙏 )

@ydshieh
Copy link
Collaborator

ydshieh commented May 8, 2025

Thank you. Have 2 nit questions regarding if we can move or have some definitions in src/transformers/testing_utils.py that we can reuse.

@yao-matrix
Copy link
Contributor Author

@ydshieh , updated the PR per your comments, thx.

@ydshieh ydshieh enabled auto-merge (squash) May 9, 2025 11:33
@ydshieh ydshieh merged commit 8f08318 into huggingface:main May 9, 2025
20 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yao-matrix yao-matrix deleted the generation-xpu branch May 11, 2025 22:45
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* enable generation fsdp/utils test cases on XPU

Signed-off-by: Yao Matrix <[email protected]>

* fix style

Signed-off-by: Yao Matrix <[email protected]>

* xx

Signed-off-by: Yao Matrix <[email protected]>

* use backend_xx APIs

Signed-off-by: Yao Matrix <[email protected]>

* fix style

Signed-off-by: Yao Matrix <[email protected]>

---------

Signed-off-by: Yao Matrix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants