Skip to content

Conversation

@simonlevine
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft May 12, 2025 16:55
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please

  1. Run pip install -e .[quality] in the repo directory and then make fixup to fix code style issues
  2. Mark the PR 'ready for review' to run tests

Once tests pass and the CI is green, ping me to merge this!

@simonlevine simonlevine marked this pull request as ready for review May 15, 2025 03:16
@simonlevine
Copy link
Contributor Author

Hi @Rocketknight1 , I think all tests are good though I see build / build_pr_documentation is still "Expected". Let me know if there's anything you need on my end. Thanks!

@Rocketknight1
Copy link
Member

@simonlevine yep, that one requires maintainer approval. I'll run it now and merge once it passes!

@Rocketknight1 Rocketknight1 enabled auto-merge (squash) May 15, 2025 13:57
@Rocketknight1 Rocketknight1 merged commit 27ef46e into huggingface:main May 15, 2025
16 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants