Fix: undefined reference to gelu in `ClippedGELUActivation` #38718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

nil0x9 wants to merge 1 commit into huggingface:main from nil0x9:main

nil0x9 commented Jun 10, 2025

Summary of This PR

Fixes a typo in activations.py that uses an undefined symbol gelu.


          fix undefined reference to gelu in ClippedGELUActivation

a8fd4c5

Member

Rocketknight1 commented Jun 10, 2025

Hi @nil0x9, gelu is defined in that file, just below the class!

Author

nil0x9 commented Jun 10, 2025

Hi @nil0x9, gelu is defined in that file, just below the class!

Oops. Somehow i missed that part. Thanks!

nil0x9 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet