Skip to content

Remove deprecated max_size support from YOLOS image processor - #38923

Closed
kartickkt wants to merge 5 commits into
huggingface:mainfrom
kartickkt:remove-max-size
Closed

kartickkt wants to merge 5 commits into
huggingface:mainfrom
kartickkt:remove-max-size

Conversation

@kartickkt

Copy link
Copy Markdown
  • Updated test_image_processor_from_dict_with_kwargs to remove the deprecated max_size argument.
  • Uses only {"shortest_edge": ...} in size, consistent with current API.
  • Ensures compatibility with the latest image processor spec.

Before submitting

All tests passed locally using pytest tests/models/yolos/test_image_processing_yolos.py.

@kartickkt

Copy link
Copy Markdown
Author

All checks have passed.
Branch is now up-to-date. Ready for review.
Happy to help further if needed!

@Rocketknight1

Rocketknight1 commented Jun 20, 2025 •

Copy link
Copy Markdown
Member

cc @qubvel @yonigozlan

@ArthurZucker

Copy link
Copy Markdown
Collaborator

Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against main using our latest tools and good practices:

Closing this one in the meantime, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants