Skip to content

Fix: unprotected import of tp plugin #39083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Fix: unprotected import of tp plugin #39083

merged 1 commit into from
Jun 27, 2025

Conversation

S1ro1
Copy link
Member

@S1ro1 S1ro1 commented Jun 27, 2025

Fixes #39077. We only use TensorParallelPlugin here and that is version checked, the matching import that is also version checked is here. The import I deleted is non-version checked and not needed.

@S1ro1 S1ro1 requested a review from ArthurZucker June 27, 2025 12:48
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the for patch?

@S1ro1 S1ro1 added the for patch Tag issues / labels that should be included in the next patch label Jun 27, 2025
@S1ro1 S1ro1 merged commit c8064be into main Jun 27, 2025
22 checks passed
@S1ro1 S1ro1 deleted the import-tp-plugin branch June 27, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for patch Tag issues / labels that should be included in the next patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'TorchTensorParallelPlugin' from 'accelerate.utils'
3 participants