Skip to content

Fix: rename 'eval_strategy' to 'evaluation_strategy' in TrainingArgum… - #39109

Closed
trevorhughdavis wants to merge 1 commit into
huggingface:mainfrom
trevorhughdavis:fix-evaluation-strategy-param
Closed

trevorhughdavis wants to merge 1 commit into
huggingface:mainfrom
trevorhughdavis:fix-evaluation-strategy-param

Conversation

@trevorhughdavis

Copy link
Copy Markdown

🐛 Bugfix: Rename eval_strategy → evaluation_strategy in TrainingArguments

This PR corrects an API mismatch in the TrainingArguments dataclass where the constructor expected eval_strategy, but Trainer, config files, and CLI use evaluation_strategy.

✅ Changes

  • Renames the field eval_strategy → evaluation_strategy
  • Updates all internal logic and references
  • Corrects docstrings and argument descriptions
  • Validated via inspect.signature(TrainingArguments.__init__)
  • Tested with full reinstallation and cache invalidation

🧪 Reproduction (Before Fix)

TrainingArguments(evaluation_strategy="epoch")
# ❌ TypeError: got an unexpected keyword argument 'evaluation_strategy'

@ArthurZucker

Copy link
Copy Markdown
Collaborator

Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against main using our latest tools and good practices:

Closing this one in the meantime, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants