Skip to content

[masking] fix Aggressive boolean conversion breaking packing implementations #39148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Jul 1, 2025

What does this PR do?

Fix Aggressive boolean conversion in the masking_utils that is breaking packing implementation

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@kashif kashif requested review from Cyrilvallez and Copilot July 1, 2025 12:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an aggressive boolean conversion issue in the masking utilities that was breaking packing implementations. The changes include:

  • Adding a regression test to ensure non-binary (fractional) attention masks are preserved.
  • Updating _preprocess_mask_arguments to detect binary masks via unique values and preserve non-binary masks.
  • Adjusting flash_attention_mask to correctly handle boolean and non-boolean masks.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/utils/test_modeling_utils.py Adds tests for preserving non-binary attention masks and ensuring correct flash attention behavior.
src/transformers/masking_utils.py Updates boolean and non-boolean mask processing in _preprocess_mask_arguments and flash_attention_mask.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Cyrilvallez
Copy link
Member

Superseded by #39194! Closing!

@Cyrilvallez Cyrilvallez closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants