Repository navigation
Fix bug with deepspeed and accelerator args in training_args.py - #39297
Closed
MuyaoLi-jimo wants to merge 3 commits into
Closed
MuyaoLi-jimo wants to merge 3 commits into
MuyaoLi-jimo wants to merge 3 commits into
Conversation
Member
|
This should have been fixed by this PR actually, not sure why this is complaining now. Mind exploring a bit the cause ? #30227 |
1 task done
This was referenced Apr 29, 2026
Collaborator
|
Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against
Closing this one in the meantime, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System Info
PyTorch version (GPU?): 2.6.0+cu124 (True)
Tensorflow version (GPU?): not installed (NA)
Flax version (CPU?/GPU?/TPU?): not installed (NA)
Jax version: not installed
JaxLib version: not installed
Using GPU in script?: T
Using distributed or parallel set-up in script?: T
Who can help?
@SunMarc and @qgallouedec
Information
Tasks
Reproduction
Right now any command with --deepspeed /path/to/json will fail and throw the following error
--deepspeed: invalid Dict valueThis bug has occurred before and was previously fixed in #24974, but unfortunately, it’s broken again.
The root cause seems to be that Python’s dataclass fields do not support Union[str, dict] when parsed from the CLI.
Expected behavior
deepspeed flag should support string.