[sliding window] revert and deprecate #39301
Merged
+71
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zucchini-nlp
added
the
for patch
|
The modular file complains when we have the a property and its setter, I think I saw that once with other models 🤔 |
zucchini-nlp
requested review from
Cyrilvallez and
ArthurZucker
and removed request for
Cyrilvallez
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Ha indeed since the methods have the same name, one is overwritten by the other in modular linter. Let me see if I can quickly patch it |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cohere2, gemma3 |
Cyrilvallez
approved these changes
Jul 9, 2025
Cyrilvallez
added a commit
that referenced
this pull request
Jul 11, 2025
* bring back and deprecate * oops --------- Co-authored-by: Cyril Vallez <[email protected]>
1 task
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
* bring back and deprecate * oops --------- Co-authored-by: Cyril Vallez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #39290