Skip to content

Skipping initialize_weights when model is quantized - #39464

Closed
dwarez wants to merge 1 commit into
huggingface:mainfrom
dwarez:skip-init-quantized
Closed

dwarez wants to merge 1 commit into
huggingface:mainfrom
dwarez:skip-init-quantized

Conversation

@dwarez

@dwarez dwarez commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Avoids to perform weights initialization when loading a quantized model. The previous implementation was checking the is_quantized condition only when trying to initialize weights with deepspeed.

Fixes #39366

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc @zach-huggingface

using deepspeed

fix: return types of some methods that are in place
@Rocketknight1

Copy link
Copy Markdown
Member

cc @MekkCyber as well!

@dwarez

dwarez commented Jul 26, 2025

Copy link
Copy Markdown
Contributor Author

@SunMarc any feedback on this?

@ArthurZucker

Copy link
Copy Markdown
Collaborator

Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against main using our latest tools and good practices:

Closing this one in the meantime, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RuntimeError when loading llmcompressor W8A8 quantized model: int8 dtype in weight initialization

3 participants