Skip to content

use untyped storage for dtensors due to deprecation - #39697

Closed
winglian wants to merge 3 commits into
huggingface:mainfrom
winglian:dtensor-storage
Closed

winglian wants to merge 3 commits into
huggingface:mainfrom
winglian:dtensor-storage

Conversation

@winglian

@winglian winglian commented Jul 26, 2025 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

TypedStorge has been deprecated for a while now pytorch/pytorch@ee28b86 and I'm getting this warning when using TP

/root/miniconda3/envs/py3.11/lib/python3.11/site-packages/transformers/pytorch_utils.py:302: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()

similarly, the nbytes size should be based on the underlying storage similar to the accelerate implementation
https://github.com/huggingface/accelerate/blob/2f075c724ccb4e38fade64db3b0627ca167b5fd2/src/accelerate/utils/modeling.py#L201-L202

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1

Copy link
Copy Markdown
Member

looks legit but cc @Cyrilvallez for TP!

@Cyrilvallez

Copy link
Copy Markdown
Member

cc @S1ro1 for a quick check!

@S1ro1

S1ro1 commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Will check this, talked about this with Wing and we have been experiencing some issues (maybe because of it), will revisit and improve, the deprecation warning is not pressing matter, as it's still around even in main torch.

@ArthurZucker

Copy link
Copy Markdown
Collaborator

Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against main using our latest tools and good practices:

Closing this one in the meantime, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants