Skip to content

Fix HfArgumentParser to filter out dict types from Union #39741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
st81 wants to merge 1 commit into from
Closed

Fix HfArgumentParser to filter out dict types from Union #39741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/transformers/hf_argparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ def _parse_dataclass_field(parser: ArgumentParser, field: dataclasses.Field):
" the argument parser only supports one type per argument."
f" Problem encountered in field '{field.name}'."
)
# filter `dict` in Union because argparse does not support it
if dict in field.type.__args__:
field.type = Union[tuple(arg for arg in field.type.__args__ if arg is not dict)]
if type(None) not in field.type.__args__:
# filter `str` in Union
field.type = field.type.__args__[0] if field.type.__args__[1] is str else field.type.__args__[1]
Expand Down