Repository navigation
Fix warning for output_attentions=True #40597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4eb1b7d
Fix attn_implementation for output_attentions
qubvel c7af552
remove setting attention, just raise warning
qubvel c415b1d
improve message
qubvel 760ff45
Update src/transformers/utils/generic.py
qubvel fc74b01
Merge branch 'main' into add-warning-for-attn
qubvel 941ee54
Merge branch 'main' into add-warning-for-attn
qubvel 5bf89f8
Merge branch 'main' into add-warning-for-attn
qubvel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flex attention returns the lse (like flash attention) - not really the same as what you would get with eager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I noticed that, but that would be captured as
attentionsand returned in ModelOutput, if I'm no missing anything. Do you have an idea of a better warning?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have an immediate solution, but 2 suggestions:
output_attentionsdoes in the docs and enable outputting the lse (would include flash attn then for example)output_lsewhich works for flash, flex etc and not on eager for example.Currently, we have a weird situation with flex 😅 doesnt need immediate change but maybe put it up for discussion internally?