Repository navigation
Conversation
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bamba, falcon_h1, granitemoehybrid, mamba2 |
vasqu
left a comment
There was a problem hiding this comment.
Can we also let the zamba2 model inherit this from mamba2 then? Let's not introduce alternatives here
And could you add a fast test to mamba2 that might catch this?
| def __init__(self, hidden_size, group_size, eps=1e-6): | ||
| super().__init__(hidden_size, group_size, eps) |
There was a problem hiding this comment.
| def __init__(self, hidden_size, group_size, eps=1e-6): | |
| super().__init__(hidden_size, group_size, eps) | |
| pass |
Weird that this even used the init here, we shouldn't need to anything on the modular side
There was a problem hiding this comment.
Same for the other modular codes
|
Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against
Closing this one in the meantime, thanks again! |
What does this PR do?
This fixes an issue for models like
mistralai/Mamba-Codestral-7B-v0.1that usemamba2architecture withn_groups>1. It is equivalent to the fix for Zamba from #35943.This issue prevents us comparing against transformers as baseline in vLLM CI for this model.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@pglorio @vasqu @ArthurZucker @hmellor