Repository navigation
feat: make audio feature extractors torch.export-able - #41033
Closed
The5cheduler wants to merge 7 commits into
Closed
The5cheduler wants to merge 7 commits into
The5cheduler wants to merge 7 commits into
Conversation
Fix huggingface#40986 Refactors the feature extraction logic for both `GraniteSpeechFeatureExtractor` and `WhisperFeatureExtractor` into separate `nn.Module` subclasses. This encapsulates the feature extraction computation in a way that is compatible with `torch.export`. A new method, `to_exportable_module()`, was added to both feature extractor classes to return an instance of these new modules. The original `__call__` and `_torch_extract_fbank_features` methods were updated to use these exportable modules. Finally, new tests were added to verify that both feature extractors can be successfully exported using `torch.export`.
Member
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: granite_speech, whisper |
Collaborator
|
Thanks for the PR, and sorry it didn't make it in! This branch is based on v4, and v5 is very different, so rather than rebasing we'd love to invite you to open a new PR against
Closing this one in the meantime, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #40986
Refactors the feature extraction logic for both
GraniteSpeechFeatureExtractorandWhisperFeatureExtractorinto separatenn.Modulesubclasses. This encapsulates the feature extraction computation in a way that is compatible withtorch.export.A new method,
to_exportable_module(), was added to both feature extractor classes to return an instance of these new modules.The original
__call__and_torch_extract_fbank_featuresmethods were updated to use these exportable modules.Finally, new tests were added to verify that both feature extractors can be successfully exported using
torch.export.What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.