Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/transformers/models/t5gemma/configuration_t5gemma.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,5 +327,14 @@ def get_text_config(self, *args, **kwargs):
# Always return self, regardless of the decoder option.
return self

# Bridge for generation/cache utils which expect `config.num_hidden_layers`.
# Prefer a top-level override if present; otherwise use the decoder's count.
@property
def num_hidden_layers(self):
if "num_hidden_layers" in self.__dict__:
return self.__dict__["num_hidden_layers"]
dec = getattr(self, "decoder", None)
return getattr(dec, "num_hidden_layers", None)


__all__ = ["T5GemmaConfig", "T5GemmaModuleConfig"]
9 changes: 9 additions & 0 deletions src/transformers/models/t5gemma/modular_t5gemma.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,15 @@ def get_text_config(self, *args, **kwargs):
# Always return self, regardless of the decoder option.
return self

# Bridge for generation/cache utils which expect `config.num_hidden_layers`.
# Prefer a top-level override if present; otherwise use the decoder's count.
@property
def num_hidden_layers(self):
if "num_hidden_layers" in self.__dict__:
return self.__dict__["num_hidden_layers"]
dec = getattr(self, "decoder", None)
return getattr(dec, "num_hidden_layers", None)


class T5GemmaRMSNorm(Gemma2RMSNorm):
pass
Expand Down
32 changes: 32 additions & 0 deletions tests/models/t5gemma/test_generation_t5gemma.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import torch

from transformers import T5GemmaConfig, T5GemmaForConditionalGeneration, T5GemmaModuleConfig


def _tiny():
return T5GemmaModuleConfig(
vocab_size=33,
hidden_size=32,
intermediate_size=128,
num_hidden_layers=2,
num_attention_heads=4,
num_key_value_heads=4,
head_dim=32,
max_position_embeddings=1024,
tie_word_embeddings=False,
layer_types=["full_attention"] * 2,
rope_theta=10000,
bos_token_id=0,
eos_token_id=1,
pad_token_id=2,
)


def test_generate_use_cache_works_for_t5gemma():
cfg = T5GemmaConfig(encoder=_tiny(), decoder=_tiny(), vocab_size=33, attn_implementation="eager")
model = T5GemmaForConditionalGeneration(cfg)

output = model.generate(torch.randint(0, 33, (1, 10)), use_cache=True, max_new_tokens=2)

assert output.shape[0] == 1
assert output.shape[1] > 0