Skip to content

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Sep 23, 2025

What does this PR do?

Remove infer_device

@cyyever cyyever force-pushed the remove_infer_device branch 2 times, most recently from 8858651 to d991c2b Compare September 23, 2025 09:20
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @SunMarc since I guess this is accelerator-linked!

@cyyever cyyever changed the title More complete infer_device Remove infer_device Oct 1, 2025
@cyyever cyyever force-pushed the remove_infer_device branch from d991c2b to 542763d Compare October 1, 2025 15:05
@cyyever
Copy link
Contributor Author

cyyever commented Oct 1, 2025

@Rocketknight1 It is not used in the code base.

@cyyever cyyever requested a review from Rocketknight1 October 1, 2025 15:06
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc enabled auto-merge (squash) October 2, 2025 10:39
@cyyever
Copy link
Contributor Author

cyyever commented Oct 3, 2025

@SunMarc It is still used in docs as code examples, IMO they can be replaced with accelerator calls. Wait until #41234 is ready.

Signed-off-by: Yuanyuan Chen <[email protected]>
auto-merge was automatically disabled October 9, 2025 12:31

Head branch was pushed to by a user without write access

@cyyever cyyever force-pushed the remove_infer_device branch 2 times, most recently from 889595d to c439bf6 Compare October 9, 2025 12:35
Signed-off-by: Yuanyuan Chen <[email protected]>
@cyyever cyyever force-pushed the remove_infer_device branch from c439bf6 to 6ca4ed2 Compare October 9, 2025 12:39
@cyyever
Copy link
Contributor Author

cyyever commented Oct 9, 2025

The documentation has been updated.

Signed-off-by: Yuanyuan Chen <[email protected]>
@Rocketknight1
Copy link
Member

@SunMarc leaving this one to you, feel free to merge if you're happy!

@SunMarc SunMarc enabled auto-merge (squash) October 9, 2025 13:57
@SunMarc SunMarc merged commit 72a3fc2 into huggingface:main Oct 9, 2025
25 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@cyyever cyyever deleted the remove_infer_device branch October 9, 2025 14:43
AhnJoonSung pushed a commit to AhnJoonSung/transformers that referenced this pull request Oct 12, 2025
* Remove infer_device

Signed-off-by: Yuanyuan Chen <[email protected]>

* Fix docs using accelerator

Signed-off-by: Yuanyuan Chen <[email protected]>

* Fix conflict

Signed-off-by: Yuanyuan Chen <[email protected]>

---------

Signed-off-by: Yuanyuan Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants