-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Import Callable from collections.abc #41130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f0775c6 to
95aef27
Compare
|
@cyyever will this break Py3.9? We might pause merging it for a couple of months until Py3.9 reaches EOL in that case. |
|
@Rocketknight1 We have switched to Py3.10 |
|
We've switched in the CI, but I don't know if we're intentionally breaking Py3.9 support yet! cc @ydshieh are we officially dropping it now? We might want to update the frontpage README in that case |
|
@Rocketknight1 Yes, we can delay it. |
95aef27 to
450b9d9
Compare
|
@Rocketknight1 @ydshieh EOL of 3.9 is Oct 1. |
|
I guess we can merge this, then! Can you check the CI and ping me once it's green? |
450b9d9 to
9fac463
Compare
Not officially yet, and I didn't know it's I got this search result which says it's Oct 31. and this https://devguide.python.org/versions/ only mention Oct but not the day. I would prefer to wait until it reaches EOL and then drop the support on our side. |
|
😂 I was told that it is tomorrow... |
9fac463 to
ee671d2
Compare
|
@Rocketknight1 @ydshieh May be it is time to ... you know |
ee671d2 to
39ee428
Compare
Rocketknight1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're in the process of deprecating support for 3.9 now, I think it's fine to merge this!
|
Can you rebase and check the CI, though? |
39ee428 to
eca0b38
Compare
|
@Rocketknight1 fixed |
b79e181 to
9ad17fa
Compare
Signed-off-by: Yuanyuan Chen <[email protected]>
9ad17fa to
440f89c
Compare
|
[For maintainers] Suggested jobs to run (before merge) run-slow: aimv2, albert, align, altclip, apertus, arcee, aria, audio_spectrogram_transformer, bamba |
|
Merging! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: Yuanyuan Chen <[email protected]>
What does this PR do?
Python 3.10 has moved
Callabletocollections.abc