Skip to content

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Sep 24, 2025

What does this PR do?

Python 3.10 has moved Callable to collections.abc

@cyyever cyyever force-pushed the import_Callable branch 3 times, most recently from f0775c6 to 95aef27 Compare September 25, 2025 11:40
@Rocketknight1
Copy link
Member

@cyyever will this break Py3.9? We might pause merging it for a couple of months until Py3.9 reaches EOL in that case.

@cyyever
Copy link
Contributor Author

cyyever commented Sep 25, 2025

@Rocketknight1 We have switched to Py3.10

@Rocketknight1
Copy link
Member

We've switched in the CI, but I don't know if we're intentionally breaking Py3.9 support yet! cc @ydshieh are we officially dropping it now? We might want to update the frontpage README in that case

@cyyever
Copy link
Contributor Author

cyyever commented Sep 25, 2025

@Rocketknight1 Yes, we can delay it.

@cyyever cyyever marked this pull request as draft September 25, 2025 14:31
@cyyever cyyever marked this pull request as ready for review September 30, 2025 13:45
@cyyever
Copy link
Contributor Author

cyyever commented Sep 30, 2025

@Rocketknight1 @ydshieh EOL of 3.9 is Oct 1.

@Rocketknight1
Copy link
Member

I guess we can merge this, then! Can you check the CI and ping me once it's green?

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 30, 2025

cc @ydshieh are we officially dropping it now?

Not officially yet, and I didn't know it's Oct 1.

I got this search result

https://endoflife.date/python

which says it's Oct 31.

and this

https://devguide.python.org/versions/

only mention Oct but not the day.

I would prefer to wait until it reaches EOL and then drop the support on our side.

@cyyever
Copy link
Contributor Author

cyyever commented Sep 30, 2025

😂 I was told that it is tomorrow...

@cyyever
Copy link
Contributor Author

cyyever commented Oct 7, 2025

@Rocketknight1 @ydshieh May be it is time to ... you know

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're in the process of deprecating support for 3.9 now, I think it's fine to merge this!

@Rocketknight1
Copy link
Member

Can you rebase and check the CI, though?

@cyyever
Copy link
Contributor Author

cyyever commented Oct 8, 2025

@Rocketknight1 fixed

@cyyever cyyever force-pushed the import_Callable branch 2 times, most recently from b79e181 to 9ad17fa Compare October 8, 2025 14:37
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: aimv2, albert, align, altclip, apertus, arcee, aria, audio_spectrogram_transformer, bamba

@Rocketknight1 Rocketknight1 enabled auto-merge (squash) October 9, 2025 12:04
@Rocketknight1
Copy link
Member

Merging!

@Rocketknight1 Rocketknight1 merged commit 2b5e4c0 into huggingface:main Oct 9, 2025
25 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@cyyever cyyever deleted the import_Callable branch October 9, 2025 12:17
AhnJoonSung pushed a commit to AhnJoonSung/transformers that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants