[voxtral] language detection + skipping lang:xx #41225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
run-slow: voxtral |
eustlb
changed the title
ArthurZucker
approved these changes
Oct 10, 2025
Comment on lines
477
to
480
| lang_prefix = "lang:xx" | ||
| if skip_special_tokens and decoded_string.startswith("lang:"): | ||
| decoded_string = decoded_string[len(lang_prefix) :] | ||
|
|
Collaborator
There was a problem hiding this comment.
if it always starts with it (no other token in between) fine, otherwise would use regex
Contributor
Author
There was a problem hiding this comment.
it should! but just in case I switched to using regex
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: voxtral |
AhnJoonSung
pushed a commit
to AhnJoonSung/transformers
that referenced
this pull request
Oct 12, 2025
* proc + doc update * improve doc * add lang:xx in decode * update voxtral test * nit * nit * update test value * use regex
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
* proc + doc update * improve doc * add lang:xx in decode * update voxtral test * nit * nit * update test value * use regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the possibility of setting
language=Noneinapply_transcription_requestfor automatic language detection.Note
This is not breaking. Instead of being required,
languageis now optional.It was a bit hidden, but Voxtral supports language detection by omitting the language token, e.g.
see here:
Other update
Important
🚨 In the specific case of Voxtral, the added
f"lang:xx"(always a two char language code since it follows ISO 639-1 alpha-2 format) is not considered as a special token bymistral-commonand is encoded/ decoded as normal text.Nevertheless we should remove it to ease users life.
Added:
MistralCommonTokenizer'sdecodetest_decode_transcription_mode