Skip to content

Conversation

@Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Oct 5, 2025

What does this PR do?

Fixes tiny incorrect import in gemma3. This is the correct class name

class PaliGemmaCausalLMOutputWithPast(ModelOutput):

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@gante @zucchini-nlp

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma3

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, interesting how modular import worked with a typo haha, looks like it is case insensitive?

just fyi @Cyrilvallez , in case you think it is a bug in modular and should be fixed :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp zucchini-nlp merged commit 0947b90 into huggingface:main Oct 6, 2025
16 checks passed
@gante
Copy link
Contributor

gante commented Oct 6, 2025

indeed, surprised this didn't blow things up :o

thank you for the fix @Sai-Suraj-27 🙏

@Cyrilvallez
Copy link
Member

Ouhh, indeed quite interesting! Thanks for the ping, will investigate! (it's probably a regex that is somehow case-insensitive indeed)

AhnJoonSung pushed a commit to AhnJoonSung/transformers that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants